[webkit-reviews] review granted: [Bug 209706] Add a ScrollLatching log channel and improve some logging functionality : [Attachment 394840] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 209706: Add a ScrollLatching log channel and improve some logging
functionality
https://bugs.webkit.org/show_bug.cgi?id=209706

Attachment 394840: Patch

https://bugs.webkit.org/attachment.cgi?id=394840&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 394840
  --> https://bugs.webkit.org/attachment.cgi?id=394840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394840&action=review

> Source/WTF/wtf/text/TextStream.h:31
> +#include <wtf/WeakPtr.h>

Would be nice to find a way to make the weak pointers easy to stream, but not
have TextStream.h need to include WeakPtr.h.

> Source/WebCore/page/mac/EventHandlerMac.mm:1058
> +    const ScrollLatchingState* latchingState = m_frame.page() ?
m_frame.page()->latchingState() : nullptr;

How about auto or auto* instead?

> Source/WebCore/page/mac/EventHandlerMac.mm:1102
> +    const ScrollLatchingState* latchingState = m_frame.page() ?
m_frame.page()->latchingState() : nullptr;

Ditto.

> Source/WebCore/page/scrolling/ScrollLatchingState.h:40
> -class ScrollLatchingState final {
> +class ScrollLatchingState {

Why this change?