[webkit-reviews] review granted: [Bug 209699] Regression(r259034): UniqueIDBDatabas object is destroyed while it's still in use : [Attachment 394794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 28 09:21:18 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 209699: Regression(r259034): UniqueIDBDatabas object is destroyed while
it's still in use
https://bugs.webkit.org/show_bug.cgi?id=209699

Attachment 394794: Patch

https://bugs.webkit.org/attachment.cgi?id=394794&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 394794
  --> https://bugs.webkit.org/attachment.cgi?id=394794
Patch

It would be nice to figure out how to use smart pointers to ensure memory
safety here; smart pointers are much easier to get right.


More information about the webkit-reviews mailing list