[webkit-reviews] review granted: [Bug 209682] [Web Animations] Crash under `KeyframeEffect::getKeyframes` for a `DeclarativeAnimation` : [Attachment 394761] Patch

Sat Mar 28 02:40:54 PDT 2020

Antoine Quint <graouts at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 209682: [Web Animations] Crash under `KeyframeEffect::getKeyframes` for a
`DeclarativeAnimation`
https://bugs.webkit.org/show_bug.cgi?id=209682

Attachment 394761: Patch

https://bugs.webkit.org/attachment.cgi?id=394761&action=review

--- Comment #3 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 394761
  --> https://bugs.webkit.org/attachment.cgi?id=394761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394761&action=review

Very nice, thanks for spotting – and fixing – that!

>
LayoutTests/webanimations/css-animation-effect-target-change-and-get-keyframes-
crash.html:1
> +<!DOCTYPE html><!-- webkit-test-runner [
experimental:WebAnimationsCSSIntegrationEnabled=true ] -->

We really don't need this but anymore, this is the default and there's No Going
Back.