[webkit-reviews] review granted: [Bug 209690] Skip stress/test-out-of-memory.js on memory limited devices. : [Attachment 394773] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 209690: Skip stress/test-out-of-memory.js on memory limited devices.
https://bugs.webkit.org/show_bug.cgi?id=209690

Attachment 394773: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=394773&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 394773
  --> https://bugs.webkit.org/attachment.cgi?id=394773
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review

r=me.

>>> JSTests/stress/test-out-of-memory.js:1
>>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture)
>> 
>> I think $memoryLimited is a superset of "arm"/"mips"?
> 
> I think you're right, but I don't see code that confirms this for sure.  This
change is conservative.  I would like to land it to green a bot, and I'll ping
the arm/mips guys to remove the condition if it is indeed unnecessary.

sounds good. Can you make sure to ping them?