[webkit-reviews] review granted: [Bug 209098] Use ANGLE_robust_client_memory to replace framebuffer/texture validation : [Attachment 394698] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 27 11:53:10 PDT 2020


Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 209098: Use ANGLE_robust_client_memory to replace framebuffer/texture
validation
https://bugs.webkit.org/show_bug.cgi?id=209098

Attachment 394698: Patch

https://bugs.webkit.org/attachment.cgi?id=394698&action=review




--- Comment #24 from Dean Jackson <dino at apple.com> ---
Comment on attachment 394698
  --> https://bugs.webkit.org/attachment.cgi?id=394698
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394698&action=review

> Source/ThirdParty/ANGLE/ChangeLog:17
> +	   Incorporated fix from anglebug.com/4504 to make
> +	   fast/canvas/webgl/uninitialized-test.html pass.
> +
> +	   Incorporated fix from anglebug.com/4518 to make:
> +	    webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer.html
> +	    webgl/2.0.0/conformance2/rendering/blitframebuffer-test.html
> +	    webgl/2.0.0/conformance2/rendering/rgb-format-support.html
> +	    webgl/2.0.0/conformance2/state/gl-object-get-calls.html
> +	    webgl/2.0.0/conformance2/textures/misc/tex-new-formats.html
> +	   pass.

I wonder what the best way to track ANGLE is if we start cherry-picking
commits? The script that James wrote was also updating our data of which ANGLE
revision we were taking, any local changes, etc.


More information about the webkit-reviews mailing list