[webkit-reviews] review granted: [Bug 209606] IndexedDB: destroy WebIDBServer when session is removed in network process : [Attachment 394624] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 27 09:09:36 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 209606: IndexedDB: destroy WebIDBServer when session is removed in network
process
https://bugs.webkit.org/show_bug.cgi?id=209606

Attachment 394624: Patch

https://bugs.webkit.org/attachment.cgi?id=394624&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 394624
  --> https://bugs.webkit.org/attachment.cgi?id=394624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394624&action=review

r=me

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:375
> +void WebIDBServer::destroy()

Since this doesn't directly delete the object, I think a name like "close" or
"invalidate" would be better.


More information about the webkit-reviews mailing list