[webkit-reviews] review granted: [Bug 209630] REGRESSION (r256577): Previous page continues to display after navigating to media document : [Attachment 394680] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 26 17:05:08 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 209630: REGRESSION (r256577): Previous page continues to display after
navigating to media document
https://bugs.webkit.org/show_bug.cgi?id=209630

Attachment 394680: Patch

https://bugs.webkit.org/attachment.cgi?id=394680&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 394680
  --> https://bugs.webkit.org/attachment.cgi?id=394680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394680&action=review

I think this should have a test.

> Source/WebCore/page/FrameView.cpp:4383
> +	   auto& document = *frame().document();

RefPtr?


More information about the webkit-reviews mailing list