[webkit-reviews] review granted: [Bug 209560] [ Mac wk1] ASSERTION FAILED: m_wrapper under WebCore::XMLHttpRequestUpload::dispatchProgressEvent : [Attachment 394636] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 209560: [ Mac wk1] ASSERTION FAILED: m_wrapper under
WebCore::XMLHttpRequestUpload::dispatchProgressEvent
https://bugs.webkit.org/show_bug.cgi?id=209560

Attachment 394636: Patch

https://bugs.webkit.org/attachment.cgi?id=394636&action=review




--- Comment #11 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 394636
  --> https://bugs.webkit.org/attachment.cgi?id=394636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394636&action=review

r=me

> Source/WebCore/ChangeLog:10
> +	   have any relevant event listeners. However, the
XMLHttpRequestUpload's wrapper lifetime is tried

tied

> Source/WebCore/ChangeLog:13
> +	   relevant listener, even though XMLHttpRequestUpload may have a
relevant event listeners. We would

listener

> Source/WebCore/xml/XMLHttpRequest.cpp:1188
>      switch (readyState()) {

Does the readyState change to DONE before or after we fire event listeners? (It
might be a problem if the answer is 'before'.)