[webkit-reviews] review granted: [Bug 209611] TypedArrays should more gracefully handle OOM during slowDownAndWasteMemory : [Attachment 394635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 26 11:52:25 PDT 2020


Tadeu Zagallo <tzagallo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 209611: TypedArrays should more gracefully handle OOM during
slowDownAndWasteMemory
https://bugs.webkit.org/show_bug.cgi?id=209611

Attachment 394635: Patch

https://bugs.webkit.org/attachment.cgi?id=394635&action=review




--- Comment #3 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 394635
  --> https://bugs.webkit.org/attachment.cgi?id=394635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394635&action=review

r=me

> Source/JavaScriptCore/API/JSTypedArray.cpp:255
> +	       return nullptr;

remove this?

> JSTests/stress/typed-array-oom-in-buffer-accessor.js:1
> +let z = new Float64Array(1000);

How slow is this test?


More information about the webkit-reviews mailing list