[webkit-reviews] review granted: [Bug 209590] REGRESSION (r254669): Expand media button doesn't work on first try on photos on reddit.com : [Attachment 394606] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 209590: REGRESSION (r254669): Expand media button doesn't work on first try
on photos on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=209590

Attachment 394606: patch

https://bugs.webkit.org/attachment.cgi?id=394606&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 394606
  --> https://bugs.webkit.org/attachment.cgi?id=394606
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394606&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:597
> +	   // For images with explicit width/height this updates the instrinsic
size as a side effect.
> +	   computeAspectRatioInformationForRenderBox(embeddedContentBox(),
constrainedSize, intrinsicRatio);

Seems obviously a good fix for now.

Are we happy with this side effect relationship here for the longer term?

Also, what guarantees embeddedContentBox() is not nullptr?