[webkit-reviews] review granted: [Bug 209593] [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its size when it's updated : [Attachment 394597] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 209593: [GTK][WPE] REGRESSION(r257775): Media controls current time label
changes its size when it's updated
https://bugs.webkit.org/show_bug.cgi?id=209593

Attachment 394597: Patch

https://bugs.webkit.org/attachment.cgi?id=394597&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 394597
  --> https://bugs.webkit.org/attachment.cgi?id=394597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review

>>> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224
>>> -video::-webkit-media-controls-time-remaining-display.hidden {
>> 
>> Why do you remove this?
> 
> Because there isn't any time remaining label. It's a bit unrelated to this
patch, I realized working on this, but I can move it to its own patch.

I would prefer you move it to its own patch but I don't care too much, your
call.