[webkit-reviews] review granted: [Bug 209106] [GTK] Crash in WebKit::LayerTreeHost::LayerTreeHost with bubblewrap sandbox enabled : [Attachment 394604] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 26 07:19:21 PDT 2020


Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 209106: [GTK] Crash in WebKit::LayerTreeHost::LayerTreeHost with bubblewrap
sandbox enabled
https://bugs.webkit.org/show_bug.cgi?id=209106

Attachment 394604: Patch

https://bugs.webkit.org/attachment.cgi?id=394604&action=review




--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 394604
  --> https://bugs.webkit.org/attachment.cgi?id=394604
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394604&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:327
> +#if PLATFORM(GTK) && PLATFORM(WAYLAND) && USE(EGL)

Again, PLATFORM(GTK) && PLATFORM(WAYLAND) is redundant, because only GTK port
uses PLATFORM(WAYLAND)


More information about the webkit-reviews mailing list