[webkit-reviews] review granted: [Bug 209532] IndexedDB: destroy UniqueIDBDatabase when it's not used : [Attachment 394473] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 209532: IndexedDB: destroy UniqueIDBDatabase when it's not used
https://bugs.webkit.org/show_bug.cgi?id=209532

Attachment 394473: Patch

https://bugs.webkit.org/attachment.cgi?id=394473&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 394473
  --> https://bugs.webkit.org/attachment.cgi?id=394473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394473&action=review

r=me

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1198
> +void UniqueIDBDatabase::destroyIfPossible()

Does this function delete the UniqueIDBDatabase object, or just disconnect it
from the server?

I think a better name might be "tryRemoveFromServer" or "tryClose".