[webkit-reviews] review granted: [Bug 209550] [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog : [Attachment 394516] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 209550: [ews] commit-queue should comment on bug if it fails to find any
modified ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=209550

Attachment 394516: Patch

https://bugs.webkit.org/attachment.cgi?id=394516&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 394516
  --> https://bugs.webkit.org/attachment.cgi?id=394516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2491
> +	       if self.getProperty('buildername', '').lower() ==
'commit-queue':

I'm r+ing this, but I feel like we've had this pattern a few different places.
I wonder if we have justification for a more general 'write comment if commit
queue' function, because I think this is the 3rd time we've done this recently.