[webkit-reviews] review granted: [Bug 209543] [ews] status-bubble should link to buildbot queue while waiting in queue : [Attachment 394493] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 209543: [ews] status-bubble should link to buildbot queue while waiting in
queue
https://bugs.webkit.org/show_bug.cgi?id=209543

Attachment 394493: Patch

https://bugs.webkit.org/attachment.cgi?id=394493&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 394493
  --> https://bugs.webkit.org/attachment.cgi?id=394493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99
> +	       if self._get_parent_queue(queue):

Is _get_parent_queue low-cost call? Because we're calling it twice if it
returns something.