[webkit-reviews] review granted: [Bug 209504] Event listeners registered with 'once' option may get garbage collected too soon : [Attachment 394510] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 10:49:33 PDT 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 209504: Event listeners registered with 'once' option may get garbage
collected too soon
https://bugs.webkit.org/show_bug.cgi?id=209504

Attachment 394510: Patch

https://bugs.webkit.org/attachment.cgi?id=394510&action=review




--- Comment #25 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 394510
  --> https://bugs.webkit.org/attachment.cgi?id=394510
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394510&action=review

r=me

> Source/JavaScriptCore/runtime/JSCJSValue.h:653
> +class EnsureStillAlive {

Let's put WTF_FORBID_HEAP_ALLOCATION, WTF_MAKE_NONCOPYABLE, and
WTF_MAKE_NONMOVABLE.


More information about the webkit-reviews mailing list