[webkit-reviews] review granted: [Bug 178175] Invalid numeric and named references should be early syntax errors : [Attachment 394400] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 178175: Invalid numeric and named references should be early syntax errors
https://bugs.webkit.org/show_bug.cgi?id=178175

Attachment 394400: Patch

https://bugs.webkit.org/attachment.cgi?id=394400&action=review




--- Comment #9 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 394400
  --> https://bugs.webkit.org/attachment.cgi?id=394400
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394400&action=review

Nice work!
(Looks like you need a rebase though.)

> Source/JavaScriptCore/yarr/YarrErrorCode.h:55
> +    InvalidNamedBackreference,

Interesting how it's `Backreference` here and `BackReference`
elsewhere...though this isn't your fault. :P