[webkit-reviews] review granted: [Bug 209524] Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself : [Attachment 394445] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 24 17:16:34 PDT 2020
Saam Barati <sbarati at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 209524: Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing
@tryGetById itself
https://bugs.webkit.org/show_bug.cgi?id=209524
Attachment 394445: Patch
https://bugs.webkit.org/attachment.cgi?id=394445&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 394445
--> https://bugs.webkit.org/attachment.cgi?id=394445
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=394445&action=review
> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1441
> + ASSERT(symbol);
seems like we should release assert
More information about the webkit-reviews
mailing list