[webkit-reviews] review granted: [Bug 209504] Event listeners registered with 'once' option may get garbage collected too soon : [Attachment 394438] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 16:44:12 PDT 2020


Saam Barati <sbarati at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 209504: Event listeners registered with 'once' option may get garbage
collected too soon
https://bugs.webkit.org/show_bug.cgi?id=209504

Attachment 394438: Patch

https://bugs.webkit.org/attachment.cgi?id=394438&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 394438
  --> https://bugs.webkit.org/attachment.cgi?id=394438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394438&action=review

r=me

> Source/WebCore/dom/EventTarget.cpp:93
> +    RefPtr<EventTarget> m_target;
> +    RefPtr<RegisteredEventListener> m_listener;

why not ref like you had before?


More information about the webkit-reviews mailing list