[webkit-reviews] review granted: [Bug 209519] REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer() : [Attachment 394433] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 209519: REGRESSION(r258314): Leak in
MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer()
https://bugs.webkit.org/show_bug.cgi?id=209519

Attachment 394433: Patch

https://bugs.webkit.org/attachment.cgi?id=394433&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 394433
  --> https://bugs.webkit.org/attachment.cgi?id=394433
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394433&action=review

> Source/WebCore/ChangeLog:8
> +	   Obey the "create" rule and adopt the results of
-copyPixelBufferForSourceTime:sourceTimeForDisplay:.

Maybe `"copy" rule` would be more appropriate given the method name?