[webkit-reviews] review granted: [Bug 209509] Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement : [Attachment 394425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 15:44:52 PDT 2020


Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 209509: Ignore in-app browser privacy checks for apps with
com.apple.private.applemediaservices entitlement
https://bugs.webkit.org/show_bug.cgi?id=209509

Attachment 394425: Patch

https://bugs.webkit.org/attachment.cgi?id=394425&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 394425
  --> https://bugs.webkit.org/attachment.cgi?id=394425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394425&action=review

Looks great! Just fix the include before landing.

> Source/WebKit/UIProcess/WebPageProxy.cpp:186
> +#include <wtf/cocoa/Entitlements.h>

This needs to be inside the #if PLATFORM(COCOA)


More information about the webkit-reviews mailing list