[webkit-reviews] review granted: [Bug 209493] Element context character rects may be in wrong coordinate system : [Attachment 394407] Patch and tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 209493: Element context character rects may be in wrong coordinate system
https://bugs.webkit.org/show_bug.cgi?id=209493

Attachment 394407: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=394407&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 394407
  --> https://bugs.webkit.org/attachment.cgi?id=394407
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=394407&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4254
> +		   rects.append({
currentRange->ownerDocument().view()->contentsToRootView(absoluteBoundingBox),
{ offsetSoFar++, stride } });

What guarantees that view() is non-null here?