[webkit-reviews] review canceled: [Bug 208793] Revise In-App Browser Privacy checks to better reflect the meaning of the flag : [Attachment 393000] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled  review:
Bug 208793: Revise In-App Browser Privacy checks to better reflect the meaning
of the flag
https://bugs.webkit.org/show_bug.cgi?id=208793

Attachment 393000: Patch

https://bugs.webkit.org/attachment.cgi?id=393000&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 393000
  --> https://bugs.webkit.org/attachment.cgi?id=393000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:3100
> +    if (isMainFrame && (m_preferences->isInAppBrowserPrivacyEnabled() ||
WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2)) {

So now this can get enabled even if the pref is disabled? See
<rdar://problem/60518694>.