[webkit-reviews] review granted: [Bug 208516] Audio fails to capture stream in WebRTC if AudioSession gets interrupted : [Attachment 394361] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208516: Audio fails to capture stream in WebRTC if AudioSession gets
interrupted
https://bugs.webkit.org/show_bug.cgi?id=208516

Attachment 394361: Patch

https://bugs.webkit.org/attachment.cgi?id=394361&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 394361
  --> https://bugs.webkit.org/attachment.cgi?id=394361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394361&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:471
> +static MediaStreamTrack* selectDocumentCaptureTrack(Document& document,
RealtimeMediaSource* activeSource, RealtimeMediaSource::Type type)

Nit: this method doesn't select a track, so maybe something like
`findActiveCaptureTrackForDocument` would be better?