[webkit-reviews] review granted: [Bug 209478] [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working : [Attachment 394367] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 08:22:21 PDT 2020


Philippe Normand <pnormand at igalia.com> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 209478: [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
https://bugs.webkit.org/show_bug.cgi?id=209478

Attachment 394367: Patch

https://bugs.webkit.org/attachment.cgi?id=394367&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 394367
  --> https://bugs.webkit.org/attachment.cgi?id=394367
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394367&action=review

> Tools/ChangeLog:6
> +	   Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the
Flatpak sandbox.

An alternative could have been to add this to `env_var_suffixes_to_keep` but
I'm also OK with this approach. Explicit is better than implicit usually :)


More information about the webkit-reviews mailing list