[webkit-reviews] review granted: [Bug 209024] [ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky crashing. : [Attachment 394326] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 23 17:39:56 PDT 2020
Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 209024: [ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky
crashing.
https://bugs.webkit.org/show_bug.cgi?id=209024
Attachment 394326: Patch
https://bugs.webkit.org/attachment.cgi?id=394326&action=review
--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 394326
--> https://bugs.webkit.org/attachment.cgi?id=394326
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=394326&action=review
> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:242
> + m_allocator->tryReset();
Can't you do this with a weak pointer instead?
More information about the webkit-reviews
mailing list