[webkit-reviews] review granted: [Bug 209327] [JSC] DFG OSR exit cannot find StructureStubInfo for put_by_val if CodeBlock is once converved from Baseline to LLInt : [Attachment 394071] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 209327: [JSC] DFG OSR exit cannot find StructureStubInfo for put_by_val if
CodeBlock is once converved from Baseline to LLInt
https://bugs.webkit.org/show_bug.cgi?id=209327

Attachment 394071: Patch

https://bugs.webkit.org/attachment.cgi?id=394071&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 394071
  --> https://bugs.webkit.org/attachment.cgi?id=394071
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394071&action=review

> Source/JavaScriptCore/ChangeLog:15
> +	       3. Since (A) collects enough information for put_by_val, (B) can
get StructureStubInfo from (A) and copmile it as inlined Setter call.

copmile => compile

> Source/JavaScriptCore/ChangeLog:20
> +	   We should just link to doneTarget of ByValInfo when the SetterCall
is generated by `op_put_by_val`. ByValInfo and its doneTarget always exists per
op_put_by_val.

nice. Once we make put_by_val SSI based, this will just go away too

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:216
> +	       StructureStubInfo* stubInfo =
baselineCodeBlockForCaller->findStubInfo(CodeOrigin(callBytecodeIndex));

move this after the if?