[webkit-reviews] review granted: [Bug 162611] [WPE][GTK] Allow distributors to brand user agent : [Attachment 393776] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 162611: [WPE][GTK] Allow distributors to brand user agent
https://bugs.webkit.org/show_bug.cgi?id=162611

Attachment 393776: Patch

https://bugs.webkit.org/attachment.cgi?id=393776&action=review




--- Comment #38 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 393776
  --> https://bugs.webkit.org/attachment.cgi?id=393776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393776&action=review

Patch looks good, thanks a lot for updating it!

> Source/WebCore/platform/glib/UserAgentGLib.cpp:147
> +    RELEASE_ASSERT_WITH_MESSAGE(isValidUserAgentHeaderValue(userAgent), "%s
is not a valid user agent header", userAgent.utf8().data());

If there are concerns about the assertion being made on each network
request, an option could be to have a boolean flag to do it only
the first time:

   static bool uaBrandCheckDone = false;
   if (!uaBrandCheckDone) {
       RELEASE_ASSERT_WITH_MESSAGE(...);
       uaBrandCheckDone =  true;
   }