[webkit-reviews] review granted: [Bug 209423] [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline : [Attachment 394259] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 209423: [Web Animations] Refactor cancelDeclarativeAnimationsForElement and
willDestroyRendererForElement on AnimationTimeline
https://bugs.webkit.org/show_bug.cgi?id=209423

Attachment 394259: Patch

https://bugs.webkit.org/attachment.cgi?id=394259&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 394259
  --> https://bugs.webkit.org/attachment.cgi?id=394259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394259&action=review

> Source/WebCore/animation/WebAnimation.h:96
> +    virtual void cancel(Silently = Silently::No);

Maybe Silently could be renamed to something more descriptive?

enum class CancelType { CompletePromises, DontCompletePromises }

or whatever the appropriate terminology is?