[webkit-reviews] review granted: [Bug 208069] DocumentTimeline / CSSTransition objects are leaking on CNN.com : [Attachment 394232] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 208069: DocumentTimeline / CSSTransition objects are leaking on CNN.com
https://bugs.webkit.org/show_bug.cgi?id=208069

Attachment 394232: Patch

https://bugs.webkit.org/attachment.cgi?id=394232&action=review




--- Comment #37 from Darin Adler <darin at apple.com> ---
Comment on attachment 394232
  --> https://bugs.webkit.org/attachment.cgi?id=394232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394232&action=review

> Source/WebCore/testing/Internals.cpp:1042
> +	   if (animation && animation->id() == id)

No need for the null check here. The set doesn’t support holding null pointers;
that’s the empty value.