[webkit-reviews] review granted: [Bug 209390] [LFC] Box::establishesBlockFormattingContext should check isInitialContainingBlock : [Attachment 394193] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 22 06:50:29 PDT 2020
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 209390: [LFC] Box::establishesBlockFormattingContext should check
isInitialContainingBlock
https://bugs.webkit.org/show_bug.cgi?id=209390
Attachment 394193: Patch
https://bugs.webkit.org/attachment.cgi?id=394193&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 394193
--> https://bugs.webkit.org/attachment.cgi?id=394193
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=394193&action=review
> Source/WebCore/layout/layouttree/LayoutBox.cpp:74
> + if (isInitialContainingBlock())
> return true;
Maybe ASSERT(parent()) after?
More information about the webkit-reviews
mailing list