[webkit-reviews] review granted: [Bug 208069] DocumentTimeline / CSSTransition objects are leaking on CNN.com : [Attachment 394178] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 208069: DocumentTimeline / CSSTransition objects are leaking on CNN.com
https://bugs.webkit.org/show_bug.cgi?id=208069

Attachment 394178: Patch

https://bugs.webkit.org/attachment.cgi?id=394178&action=review




--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 394178
  --> https://bugs.webkit.org/attachment.cgi?id=394178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394178&action=review

> Source/WebCore/ChangeLog:12
> +	   (aka CSSAnimationCollection) member on ElementAnimationRareData
being replaced to the new list, but the old list not being cleared from its
members.

"being replaced by"?

> Source/WebCore/testing/Internals.cpp:1039
> +bool Internals::animationWithIdExists(const String& id) const

Avoid 'id' because it's a reserved word in ObjectiveC

> Source/WebCore/testing/Internals.h:213
> +    bool animationWithIdExists(const String&) const;

How does the animation get an ID in the first place?