[webkit-reviews] review granted: [Bug 205640] An animated PNG plays the frames one time more than the image loopCount : [Attachment 394148] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 20 17:39:28 PDT 2020


Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 205640: An animated PNG plays the frames one time more than the image
loopCount
https://bugs.webkit.org/show_bug.cgi?id=205640

Attachment 394148: Patch

https://bugs.webkit.org/attachment.cgi?id=394148&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 394148
  --> https://bugs.webkit.org/attachment.cgi?id=394148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394148&action=review

> Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:105
> +bool isGIFImageType(const StringView& imageType)

Should be just StringView; actually more efficient than const&.

> Source/WebCore/platform/graphics/cg/UTIRegistry.h:38
> +bool isGIFImageType(const StringView&);

Should be just StringView.


More information about the webkit-reviews mailing list