[webkit-reviews] review granted: [Bug 205640] An animated PNG plays the frames one time more than the image loopCount : [Attachment 394139] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 205640: An animated PNG plays the frames one time more than the image
loopCount
https://bugs.webkit.org/show_bug.cgi?id=205640

Attachment 394139: Patch

https://bugs.webkit.org/attachment.cgi?id=394139&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 394139
  --> https://bugs.webkit.org/attachment.cgi?id=394139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394139&action=review

> Source/WebCore/ChangeLog:9
> +	   Make the repetitionCount calculation for GIFs different from it for
other
> +	   image formats.

This seems to be a workaround for a bug in the values of the property
"LoopCount" as set by the ImageIO framework. It’s OK to have a workaround in
WebKit, but the whole point of this property and framework is to abstract
differences between image types.

Ideally we should get this fixed in ImageIO some day and remove our workaround.

> Source/WebCore/platform/graphics/cg/UTIRegistry.h:38
> +bool iGIFImageType(const String&);

Any new function like this should use StringView instead of const String&.

Also, there’s a missing "s" here in "is".