[webkit-reviews] review granted: [Bug 201608] Replace "deferred element focus" functionality with alternative solution : [Attachment 393953] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 201608: Replace "deferred element focus" functionality with alternative
solution
https://bugs.webkit.org/show_bug.cgi?id=201608

Attachment 393953: Patch

https://bugs.webkit.org/attachment.cgi?id=393953&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 393953
  --> https://bugs.webkit.org/attachment.cgi?id=393953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393953&action=review

>> Source/WebKit/ChangeLog:21
>> +	    defocuing logic in the UI process and prevents fixing
<https://bugs.webkit.org/show_bug.cgi?id=199960>.
> 
> defocuing => defocusing

Yes, that, or blurring.

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3055
>> +	    scheduleFullEditorStateUpdate();
> 
> Maybe extract this into a private member function? Could be called
layoutAndSendEditorStateIfNeeded()?

IMO, this is okay as-is.