[webkit-reviews] review denied: [Bug 209244] [Cocoa] Fix launch time regression with CF prefs direct mode enabled : [Attachment 394102] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 209244: [Cocoa] Fix launch time regression with CF prefs direct mode
enabled
https://bugs.webkit.org/show_bug.cgi?id=209244

Attachment 394102: Patch

https://bugs.webkit.org/attachment.cgi?id=394102&action=review




--- Comment #11 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 394102
  --> https://bugs.webkit.org/attachment.cgi?id=394102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394102&action=review

> Source/WTF/wtf/PlatformEnable.h:878
> +#if PLATFORM(COCOA)
> +#define ENABLE_CFPREFS_DIRECT_MODE 1
> +#else
>  #define ENABLE_CFPREFS_DIRECT_MODE 0
> +#endif

Please put this in PlatformEnableCocoa.h, and add a default value of
ENABLE_CFPREFS_DIRECT_MODE above.

> Source/WebKit/ChangeLog:16
> +

Why is ok to wait for ui process activation? It seems like this will have a
change in behavior. 

If this change is ok, please add a test showing the change in behavior.