[webkit-reviews] review granted: [Bug 209334] [ews] commit-queue should comment on bug if patch fails to apply : [Attachment 394080] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 209334: [ews] commit-queue should comment on bug if patch fails to apply
https://bugs.webkit.org/show_bug.cgi?id=209334

Attachment 394080: Patch

https://bugs.webkit.org/attachment.cgi?id=394080&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 394080
  --> https://bugs.webkit.org/attachment.cgi?id=394080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394080&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:230
> +	   message = 'Patch {} does not apply'.format(patch_id)

Shouldn't we define the message only if the return-code is a failure?