[webkit-reviews] review granted: [Bug 209119] [GStreamer][MSE] Youtube 'live stream'/H264 URLs fail to play, VP8/9 URLs play OK : [Attachment 393986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 19 10:03:59 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 209119: [GStreamer][MSE] Youtube 'live stream'/H264 URLs fail to play,
VP8/9 URLs play OK
https://bugs.webkit.org/show_bug.cgi?id=209119

Attachment 393986: Patch

https://bugs.webkit.org/attachment.cgi?id=393986&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 393986
  --> https://bugs.webkit.org/attachment.cgi?id=393986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393986&action=review

If Alicia says it's ok, I'm good as well.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:464
> +    static MediaTime decodeTimeOffset = MediaTime::invalidTime();

I think this should be MediaTime m_decodeTimeOffset in AppendPipeline.h.


More information about the webkit-reviews mailing list