[webkit-reviews] review granted: [Bug 194007] [JSC][BigEndians] Several JSC stress tests failing : [Attachment 364657] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 194007: [JSC][BigEndians] Several JSC stress tests failing
https://bugs.webkit.org/show_bug.cgi?id=194007

Attachment 364657: Patch

https://bugs.webkit.org/attachment.cgi?id=364657&action=review




--- Comment #20 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 364657
  --> https://bugs.webkit.org/attachment.cgi?id=364657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364657&action=review

Skimming over this patch, it looks good to me. Hope it still applies more or
less cleanly.

> JSTests/stress/dataview-jit-set-nan.js:57
> -	   storeLittleEndian(dv, 0, 12912.124123215122);
> +	   store(dv, 0, 12912.124123215122, isLittleEndian);
> +	   //storeLittleEndian(dv, 0,
adjustForEndianessFloat32(12912.124123215122));

Please report a new bug for this, and add a FIXME comment pointing to the bug.