[webkit-reviews] review denied: [Bug 209223] [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime : [Attachment 393962] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 209223: [Flatpak SDK] Release logs not sent to journald when running within
the SDK runtime
https://bugs.webkit.org/show_bug.cgi?id=209223

Attachment 393962: Patch

https://bugs.webkit.org/attachment.cgi?id=393962&action=review




--- Comment #10 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 393962
  --> https://bugs.webkit.org/attachment.cgi?id=393962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393962&action=review

> Tools/flatpak/flatpakutils.py:-579
> -			      # Workaround for https://webkit.org/b/187384 to
have our own perl modules usable inside the sandbox
> -			      # as setting the PERL5LIB envvar won't work
inside apache (and for scripts using `perl -T``).
> -			      "--bind-mount=/run/host/%s=%s" %
(tempfile.gettempdir(), tempfile.gettempdir()),

the crash log code assumes /run/host its there, if you delete this you have to
adapt that. grep for /run/host on Tools

> Tools/flatpak/flatpakutils.py:583
> +			     
"--bind-mount=/run/systemd/journal=/run/systemd/journal",

I wonder about ICECC support. Doesn't it need to access
/run/icecc/iceccd.socket from the host?