[webkit-reviews] review denied: [Bug 209278] [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set : [Attachment 393972] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 209278: [GTK][WPE] REGRESSION(r258626): flatpak is used even when
WEBKIT_JHBUILD is set
https://bugs.webkit.org/show_bug.cgi?id=209278

Attachment 393972: Patch

https://bugs.webkit.org/attachment.cgi?id=393972&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 393972
  --> https://bugs.webkit.org/attachment.cgi?id=393972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393972&action=review

> Tools/ChangeLog:9
> +	   This happens when using an external jhbuild, because
shouldUseFlatpak() assumes that no command prefix always
> +	   means flatpak.

What's failing exactly?

> Tools/Scripts/webkitdirs.pm:2176
> +    if (defined $ENV{'WEBKIT_JHBUILD'}) {

The env var value should be checked.