[webkit-reviews] review requested: [Bug 209146] Fix many warnings with Clang 7.0 on GTK x86-64 in Debug. : [Attachment 393970] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 19 06:08:37 PDT 2020
Charlie Turner <cturner at igalia.com> has asked for review:
Bug 209146: Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
https://bugs.webkit.org/show_bug.cgi?id=209146
Attachment 393970: Patch
https://bugs.webkit.org/attachment.cgi?id=393970&action=review
--- Comment #18 from Charlie Turner <cturner at igalia.com> ---
Created attachment 393970
--> https://bugs.webkit.org/attachment.cgi?id=393970&action=review
Patch
r258635 landed unreviewed while this was being reviewed, and conflicted with
its approach of eliminating unused parameter warnings. They were using
UNUSED_PARAM(), I am deleting the parameter names as suggested by Darin. So, in
affect this patch is now acting as a revert of r258635 as well as a more
general warnings suppression patch.
More information about the webkit-reviews
mailing list