[webkit-reviews] review denied: [Bug 207372] [WPE][WebDriver] Implement user prompt support : [Attachment 393940] Updated patch after aperez comments.

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 207372: [WPE][WebDriver] Implement user prompt support
https://bugs.webkit.org/show_bug.cgi?id=207372

Attachment 393940: Updated patch after aperez comments.

https://bugs.webkit.org/attachment.cgi?id=393940&action=review




--- Comment #11 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 393940
  --> https://bugs.webkit.org/attachment.cgi?id=393940
Updated patch after aperez comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=393940&action=review

This approach looks neater to me, I have just one comment more,
and unless somebody (and with “somebody” I am thinking Carlos
García) has concerns we will be ready to land this :)

> Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:36
> +    webkit_script_dialog_close(dialog);

Here we should call webkit_script_dialog_unref(dialog) to avoid
leaking it. That will be enough because the only ref will be the
one added in the webkitWebViewScriptDialog() function, so the
object will reach a refcount of zero and the webkit_script_dialog()
is called during destruction.

> Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:44
> +    webkit_script_dialog_close(dialog);

Same here, replace with a call to webkit_script_dialog_unref().