[webkit-reviews] review denied: [Bug 209258] Correctly set up context for Data Detectors : [Attachment 393922] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 209258: Correctly set up context for Data Detectors
https://bugs.webkit.org/show_bug.cgi?id=209258

Attachment 393922: Patch

https://bugs.webkit.org/attachment.cgi?id=393922&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 393922
  --> https://bugs.webkit.org/attachment.cgi?id=393922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393922&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:744
> +    [ddContextMenuActionClass updateContext:context
withSourceRect:sourceRect];

You need to use the return value of this method, it doesn't/can't mutate the
one passed in

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6754
> +    [ddContextMenuActionClass updateContext:context.get()
withSourceRect:frameInContainerViewCoordinates];

You need to use the return value of this method, it doesn't/can't mutate the
one passed in