[webkit-reviews] review granted: [Bug 197819] eventSender.monitorWheelEvents() is very fragile : [Attachment 393917] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 197819: eventSender.monitorWheelEvents() is very fragile
https://bugs.webkit.org/show_bug.cgi?id=197819

Attachment 393917: Patch

https://bugs.webkit.org/attachment.cgi?id=393917&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 393917
  --> https://bugs.webkit.org/attachment.cgi?id=393917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393917&action=review

> Tools/DumpRenderTree/mac/EventSendingController.mm:855
> +    [[[mainFrame frameView] documentView] layout];

!

> Tools/DumpRenderTree/mac/EventSendingController.mm:881
> +    if (phase == 4 /* kCGScrollPhaseEnded */ || phase == 8 /*
kCGScrollPhaseCancelled */)

Why can't we use the constants?