[webkit-reviews] review granted: [Bug 199960] [iOS] ASSERTION FAILURE: !isMissingPostLayoutData in WebKit::EditorState::postLayoutData() : [Attachment 393900] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 199960: [iOS] ASSERTION FAILURE: !isMissingPostLayoutData in
WebKit::EditorState::postLayoutData()
https://bugs.webkit.org/show_bug.cgi?id=199960

Attachment 393900: Patch

https://bugs.webkit.org/attachment.cgi?id=393900&action=review




--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 393900
  --> https://bugs.webkit.org/attachment.cgi?id=393900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393900&action=review

> Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:316
> +void WebPage::platformEditorStateCommon(const Frame& frame, EditorState&
result) const

This should be getEditorStateCommon or computeEditorStateCommon.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1067
> +    auto& document = *frame->document();

RefPtr<Document>?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:237
> +void WebPage::platformEditorState(Frame& frame, EditorState& result) const

get/computeEditorState.

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:136
> +void WebPage::platformEditorState(Frame& frame, EditorState& result) const

get/compute