[webkit-reviews] review granted: [Bug 209246] Pass isNavigatingToAppBoundDomain for speculative loads, preconnect tasks and downloads : [Attachment 393895] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 209246: Pass isNavigatingToAppBoundDomain for speculative loads, preconnect
tasks and downloads
https://bugs.webkit.org/show_bug.cgi?id=209246

Attachment 393895: Patch

https://bugs.webkit.org/attachment.cgi?id=393895&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 393895
  --> https://bugs.webkit.org/attachment.cgi?id=393895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393895&action=review

I think the name NavigatingToAppBoundDomain is no longer correct, but I'm ok
with it in this patch as long as there's a plan to rename it.
r=me

> Source/WebKit/Shared/NavigatingToAppBoundDomain.h:36
> +template<> struct EnumTraits<WebKit::NavigatingToAppBoundDomain> {

Yes, I agree with John.  Please remove this unneeded bit.

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:307
> +   
webProcess.ensureNetworkProcessConnection().connection().send(Messages::Network
ConnectionToWebProcess::ConvertMainResourceLoadToDownload(mainResourceLoadIdent
ifier, policyDownloadID, request, response,
page()->isNavigatingToAppBoundDomain()), 0);

We should probably null check page here and above.