[webkit-reviews] review denied: [Bug 209223] [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime : [Attachment 393870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 18 14:30:27 PDT 2020


Aakash Jain <aakash_jain at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 209223: [Flatpak SDK] Release logs not sent to journald when running within
the SDK runtime
https://bugs.webkit.org/show_bug.cgi?id=209223

Attachment 393870: Patch

https://bugs.webkit.org/attachment.cgi?id=393870&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 393870
  --> https://bugs.webkit.org/attachment.cgi?id=393870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393870&action=review

> Tools/flatpak/flatpakutils.py:580
> +			      # systemd journal socket. So white-list
everything in /run. ¯\_(ã)_/¯

Seems like unintentional characters here: ¯\_(ã)_/¯
breaks gtk api-tests.
https://ews-build.webkit.org/#/builders/34/builds/5027/steps/10/logs/stdio


More information about the webkit-reviews mailing list