[webkit-reviews] review granted: [Bug 209146] Fix many warnings with Clang 7.0 on GTK x86-64 in Debug. : [Attachment 393851] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Charlie Turner <cturner at igalia.com>'s
request for review:
Bug 209146: Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
https://bugs.webkit.org/show_bug.cgi?id=209146

Attachment 393851: Patch

https://bugs.webkit.org/attachment.cgi?id=393851&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 393851
  --> https://bugs.webkit.org/attachment.cgi?id=393851
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393851&action=review

> Source/WebCore/loader/cache/CachedResource.cpp:336
> +#if !RELEASE_LOG_DISABLED
>	       auto& frame = frameRef.get();
>	       RELEASE_LOG_IF(loggingAllowed, Network, "%p - [pageID=%" PRIu64
", frameID=%" PRIu64 "] CachedResource::load: Unable to create
SubresourceLoader", this, PAGE_ID(frame), FRAME_ID(frame));
> +#endif

I personally would have just repeated frameRef.get() three times, making the
RELEASE_LOG_IF line a bit longer to keep this a little more tidy.