[webkit-reviews] review granted: [Bug 209173] Make URL::path() return a StringView : [Attachment 393850] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 209173: Make URL::path() return a StringView
https://bugs.webkit.org/show_bug.cgi?id=209173

Attachment 393850: Patch

https://bugs.webkit.org/attachment.cgi?id=393850&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 393850
  --> https://bugs.webkit.org/attachment.cgi?id=393850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393850&action=review

> Source/WebCore/platform/text/TextEncoding.cpp:193
> +	   return string.toString();

Does an empty StringView's .toString return "" or { }?	I think we should
return that here instead.

> Source/WebCore/workers/service/ServiceWorkerJob.cpp:135
> +    if (maxScopeString.isNull() || !scopeString.startsWith(maxScopeString))

Why did we add a null check here?